A couple of unrelated minor fixes #2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Jan 25, 2018
src/Makefile
Outdated
| nnet2: base util matrix lat gmm hmm tree transform cudamatrix | ||
| nnet3: base util matrix lat gmm hmm tree transform cudamatrix chain fstext | ||
| rnnlm: base util matrix cudamatrix nnet3 lm hmm | ||
| rnnlm: base util matrix cudamatrix nnet3 chain lm hmm |
Contributor
There was a problem hiding this comment.
what linking error was this intended to solve?
Contributor
Author
There was a problem hiding this comment.
sorry, it was caused by a problem in my environment. removed this.
danpovey
reviewed
Jan 25, 2018
| /export/b0{5,6,7,8}/$USER/kaldi-data/egs/librispeech-$(date +'%m_%d_%H_%M')/s5c/$dir/egs/storage $dir/egs/storage | ||
| fi | ||
|
|
||
| mkdir -p $dir/egs |
Contributor
There was a problem hiding this comment.
hm.
Actually I think the better fix would be to just remove the following line touch $dir/egs/.nodelete.
that's what would fail.
Contributor
There was a problem hiding this comment.
@akreal, could you please change this so it removes the line touch $dir/egs/.nodelete instead of adding this line?
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.