Skip to content

[src] Fix bug found by Hainan and Yiming regarding looped computation.#1616

Merged
danpovey merged 1 commit intokaldi-asr:kaldi_52from
danpovey:kaldi_52_looped_fix
May 11, 2017
Merged

[src] Fix bug found by Hainan and Yiming regarding looped computation.#1616
danpovey merged 1 commit intokaldi-asr:kaldi_52from
danpovey:kaldi_52_looped_fix

Conversation

@danpovey
Copy link
Contributor

No description provided.

@danpovey
Copy link
Contributor Author

@freewym, this is a bug fix for the problem that you and Hainan encountered with the RNNLM stuff.
Unfortunately it would not be trivial to fix it in master, so the fix is only available in kaldi_52. This means you will have to upgrade all your RNNLM work to start from the kaldi_52 branch.
However, it needs testing to make sure that it doesn't break regular online decoding.

Could you please run online decoding in some setup with this version of the code? Often the scripts don't run it by default even if they support it, you have to add some kind of flag.

@freewym
Copy link
Contributor

freewym commented May 10, 2017

OK

@freewym
Copy link
Contributor

freewym commented May 10, 2017

Do I need to do like what is in egs/mini_librispeech/s5/local/chain/run_tdnn.sh, i.e.,
call steps/online/nnet3/prepare_online_decoding.sh and steps/online/nnet3/decode.sh?
If yes, can I just use mini_libirspeech to test?

@danpovey
Copy link
Contributor Author

danpovey commented May 10, 2017 via email

@freewym
Copy link
Contributor

freewym commented May 11, 2017

I tested the online decoding on mini-librispeech using chain+TDNN and xent+TDNN-LSTM respectively, and got exactly the same results as before.

@danpovey
Copy link
Contributor Author

OK, thanks; I'll merge, and if any other problems with this show up we'll address them at that time.

@danpovey danpovey merged commit 7201337 into kaldi-asr:kaldi_52 May 11, 2017
@freewym
Copy link
Contributor

freewym commented May 11, 2017

@hainan-xv just merged it with kaldi_52 and tested it on our rnnlm rescoring, and the problem looks resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants