[src] WaveData::Read streams of unspecified length#1590
Merged
danpovey merged 2 commits intokaldi-asr:kaldi_52from May 3, 2017
Merged
[src] WaveData::Read streams of unspecified length#1590danpovey merged 2 commits intokaldi-asr:kaldi_52from
danpovey merged 2 commits intokaldi-asr:kaldi_52from
Conversation
Slightly modified work of @Minhua722 lifted from PR kaldi-asr#338. Key changes: * Only 16-bit signed linear PCM sample format is supported. For everything else, there is SoX. * class WaveInfo separated from WaveData, and now used by wav-to-duration. * Added basic wave reader tests. Closes: kaldi-asr#88 Closes: kaldi-asr#338 Closes: kaldi-asr#1567
Contributor
|
Thanks! I'll try to test again, and merge, in the next few days |
danpovey
reviewed
Apr 29, 2017
src/feat/wave-reader.cc
Outdated
| if (strcmp(tmp, expected)) | ||
| KALDI_ERR << "WaveData: expected " << expected << ", got " << tmp; | ||
| } | ||
| // A utility class closure for reading wave header |
Contributor
There was a problem hiding this comment.
'closure' is not a concept that will be familiar to many readers; can you please rename this class and remove 'closure' from the comment?
Contributor
Author
There was a problem hiding this comment.
Done. Hope the new name works. I would generally avoid calling anything "HeaderReader."
danpovey
reviewed
Apr 29, 2017
src/featbin/wav-to-duration.cc
Outdated
| BaseFloat duration = wave_data.Duration(); | ||
| const WaveInfo &wave_info = wav_reader.Value(); | ||
| if (wave_info.IsStreamed()) | ||
| KALDI_ERR << "Error: member " << key << " has no manifest duration. " |
Contributor
There was a problem hiding this comment.
can you please change 'manifest duration' -> 'duration in header'?
Contributor
Author
|
I am on a trip, will do on Tuesday! |
Contributor
|
Thanks! Merging. |
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
…multi-chunk wavs. Thanks: @Minhua722 (kaldi-asr#1590)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly modified work of @Minhua722 lifted from PR #338. Key changes:
class WaveInfoseparated fromWaveData, and now used bywav-to-duration.Closes: #88
Closes: #338
Closes: #1567