[src] Change how combination works with batch-norm. Only for nnet3, …#1587
Merged
danpovey merged 4 commits intokaldi-asr:kaldi_52from Apr 28, 2017
Merged
[src] Change how combination works with batch-norm. Only for nnet3, …#1587danpovey merged 4 commits intokaldi-asr:kaldi_52from
danpovey merged 4 commits intokaldi-asr:kaldi_52from
Conversation
…eeds to be duplicated for chain.
Contributor
Author
|
Also, I have not tested this at all, I am leaving that to you. |
Contributor
|
@danpovey get it |
Contributor
Author
|
@GaofengCheng, these changes only affect the final 'combine' stage, so to test you can run with --cleanup=false, change the code, and run just the final combination stage (set --train-stage to the number of iters). |
…s from previous commit
…atch-norm to CIFAR recipe
Contributor
Author
|
I've tested this enough that I'm pretty confident in it, so merging. |
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
…atch-norm to cifar recipe (kaldi-asr#1587)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…needs to be duplicated for chain.
@GaofengCheng, you'll have to do some work to duplicate all these changes for the 'chain' tools. Check each and every diff line because I think all or nearly all of them need to also be made on similar 'chain'-based code. And that code might be in nnet3/ or chain/ or nnet3bin/ or chainbin/, so grep around for similarly named things.