WaveData::Read unspecified streams; unsupport 8 and 32 bit formats#1546
WaveData::Read unspecified streams; unsupport 8 and 32 bit formats#1546danpovey merged 3 commits intokaldi-asr:kaldi_52from
Conversation
|
Thanks. |
|
@danpovey, do you want to cherry-pick the commits after they are merged into master into a separate branch and a PR? The structure of the branch kaldi_52 is quite complex and non-obvious, and it is divergent in respect to master. |
|
@danpovey Or do you mean just rebase my changes onto kaldi_52 and make the PR against kaldi_52 only? |
|
Oops, it goes the other way round. I think I understand now what you want me to do with my PR. |
|
Rebased to kaldi_52 |
|
Thanks! So this is ready to merge? |
|
Yes, please. Tests only cover basic positive cases (expected wave data format, no malformed files etc.), but at the very least I verified that the new functionality worked. |
|
I have reverted this PR from the command line since the 'revert' button from github didn't work. |
…ats (kaldi-asr#1546) Based on some earlier work of @Minhua722 lifted from PR kaldi-asr#338.
…bit formats (kaldi-asr#1546)" This reverts commit 0799b4d.
This continues and supersedes #338 by @Minhua722.
Still missing tests, will add some over the weekend.