-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix rnnlm related code style #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,11 @@ | |
| #ifndef KALDI_LM_ARPA_FILE_PARSER_H_ | ||
| #define KALDI_LM_ARPA_FILE_PARSER_H_ | ||
|
|
||
| #include <fst/fst-decl.h> | ||
|
|
||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include <fst/fst-decl.h> | ||
|
|
||
| #include "base/kaldi-types.h" | ||
| #include "itf/options-itf.h" | ||
|
|
||
|
|
@@ -38,7 +38,7 @@ struct ArpaParseOptions { | |
| enum OovHandling { | ||
| kRaiseError, ///< Abort on OOV words | ||
| kAddToSymbols, ///< Add novel words to the symbol table. | ||
| kReplaceWithUnk, ///< Replace OOV words with <unk>. | ||
| kReplaceWithUnk, ///< Replace OOV words with <unk>. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not very sure about this, but I think there should be a space after the comment // thing? //this is bad
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just followed the rule "two spaces between code and comments". I'll modify it as what you suggested. |
||
| kSkipNGram ///< Skip n-gram with OOV word and continue. | ||
| }; | ||
|
|
||
|
|
@@ -59,7 +59,7 @@ struct ArpaParseOptions { | |
| int32 eos_symbol; ///< Symbol for </s>, Required non-epsilon. | ||
| int32 unk_symbol; ///< Symbol for <unk>, Required for kReplaceWithUnk. | ||
| OovHandling oov_handling; ///< How to handle OOV words in the file. | ||
| int32 max_warnings; ///< Maximum warnings to report, <0 unlimited. | ||
| int32 max_warnings; ///< Maximum warnings to report, <0 unlimited. | ||
| }; | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is need to change this file