change utils/mkgraph.sh so that it ignores the mono,left-biphone and … #1260
Conversation
egs/wsj/s5/utils/mkgraph.sh
Outdated
| [ "$1" == "--quinphone" ] && context=quinphone && shift; | ||
| for x in `seq 4`; do | ||
| [ "$1" == "--mono" -o "$1" == "left-biphone" -o "$1" == "--quinphone" ] && shift && \ | ||
| echo "WARNING: The '--mono, --left-biphone and --qunphone' options are deprecated and ignored. Please delete it!" |
There was a problem hiding this comment.
please spell quinphone right. Also remove the words "Please delete it!". Firstly, I don't think this adds useful information; secondly, the exclamation mark '!' is problematic in interactive shells, if not enclosed in single quotes; it can cause crashes.
egs/wsj/s5/utils/mkgraph.sh
Outdated
| echo " --quinphone # For models with 5-phone context (3 is default)" | ||
| echo " --left-biphone # For left biphone models" | ||
| echo "For other accepted options, see top of script." | ||
| echo " --remove-oov # For remove out-of-vocabulary." |
There was a problem hiding this comment.
Replace 'For remove out-of-vocabulary' with the following text, suitably line-broken:
If true, any paths containing the OOV symbol (obtained from oov.int in the lang directory) are removed from the graph G.fst during compilation.
egs/wsj/s5/utils/mkgraph.sh
Outdated
| echo " --left-biphone # For left biphone models" | ||
| echo "For other accepted options, see top of script." | ||
| echo " --remove-oov # For remove out-of-vocabulary." | ||
| echo " --transition-scale # For the scale on transition probabilities." |
There was a problem hiding this comment.
For the scale -> Scaling factor on
egs/wsj/s5/utils/mkgraph.sh
Outdated
| echo "For other accepted options, see top of script." | ||
| echo " --remove-oov # For remove out-of-vocabulary." | ||
| echo " --transition-scale # For the scale on transition probabilities." | ||
| echo " --self-loop-scale # For the scale on self-loop." |
There was a problem hiding this comment.
Please replace 'For the scale on self-loop' with this:
Please see: http://kaldi-asr.org/doc/hmm.html#hmm_scale
egs/wsj/s5/utils/mkgraph.sh
Outdated
| echo " --remove-oov # For remove out-of-vocabulary." | ||
| echo " --transition-scale # For the scale on transition probabilities." | ||
| echo " --self-loop-scale # For the scale on self-loop." | ||
| echo "Attention, please! Currently the '--mono, --left-biphone and --qunphone' options" |
There was a problem hiding this comment.
Please reword to:
"Note: the --mono, --left-biphone and --quinphone options are now deprecated"
"and will be ignored."
…quinphone options and fix the checked-in example scripts fix the utils/mkgraph.sh
|
@danpovey Best wishes, |
|
Thanks! Merging. |
2 participants
@danpovey
Hi Dan,
I modify the utils/mkgraph.sh and other checked-in example scripts to ignore the "--mono --left-biphone and --quinphone" options.
Please check it. Thank you for your time.
Best wishes,
Hang