-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Adding dropout schedule option to nnet3 #1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e97df65
dropout_schedule: Adding dropout schedule to scripts
vimalmanohar 8d26ce0
dropout_schedule: Add set-dropout-proportion in nnet3 utils
vimalmanohar 1424c57
Changing option
vimalmanohar 818d495
dropout_schedule: Print dropout info
vimalmanohar 3342dd8
dropout_schedule: Adding more comments and fixing bug
vimalmanohar f17b0fc
dropout_schedule: Bug fix
vimalmanohar 5a6a9b1
dropout_schedule: Fixed bug
vimalmanohar 4ece089
dropout_schedule: Fixing logging
vimalmanohar 0dd66c1
dropout_schedule: Not printing shrinkage when its 1.0
vimalmanohar f6d25a2
Merging
vimalmanohar 635bb6e
Merge branch 'master' of github.com:kaldi-asr/kaldi into dropout_sche…
vimalmanohar 7109c43
change dropout_parser strategy
GaofengCheng 5435f23
adding frame level dropout to TDNN+LSTM on AMI SDM1 #1248
GaofengCheng 7899760
dropout_schedule: Add strict checking of dropout schedule
vimalmanohar 18404a9
Merge branch 'dropout_schedule' into nnet3-dropout
vimalmanohar 4371f7a
Merge pull request #6 from GaofengCheng/nnet3-dropout
vimalmanohar c86b3e4
dropout_schedule: Better way to fix the same data proportion in sched…
vimalmanohar bc72ed6
dropout_schedule: SetDropoutProportion to 0 in nnet-combine and nnet-…
vimalmanohar 879e2e1
dropout_schedule: Adding back the function SetDropoutProportion that …
vimalmanohar 18a5c58
dropout_schedule: Fixing deprecated dropout option
vimalmanohar d7ebc31
dropout_schedule: Sorting models to combine for easy reading of values
vimalmanohar 8484c58
dropout_schedule: Merging from master
vimalmanohar a01ed13
dropout: Minor bug fix
vimalmanohar e6d886a
dropout_schedule: Simplying dropout in script
vimalmanohar 4e8960b
dropout_schedule: Simplified dropout schedule functions
vimalmanohar a6b9389
dropout_schedule: removing example script
vimalmanohar df7e7b6
dropout_schedule: fixing minor errors
vimalmanohar c978be3
dropout_schedule: Made functions internal
vimalmanohar e9d498b
dropout_schedule: Added self test
vimalmanohar d8adee9
dropout_schedule: removing dropout option
vimalmanohar 09cc27b
dropout_schedule: Add more examples
vimalmanohar 2e94018
dropout_schedule: Made self_test to not run on import
vimalmanohar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if you just imported get_dropout_edit_string, because that's the only function we need from there, and if you just import the one function it's clear that that's the only one that's the real interface. You could rename all the others with underscores at the start of their names (assuming they really are internal to the module and assuming that's what the Google style guide recommends in such circumstances).