adding CER scoring capability#1174
Conversation
|
Tested on HKUST |
egs/wsj/s5/steps/score_kaldi.sh
Outdated
| fi | ||
| fi | ||
|
|
||
| if $cer && [ $stage -le 2 ] ; then |
There was a problem hiding this comment.
Since this is a special case, I don't like having such a big block.
How about calling steps/scoring/score_kaldi_cer.sh, and moving steps/score_kaldi.sh to steps/scoring/ and making it a link? [trying to move to subdirs in steps/]
There was a problem hiding this comment.
i mean move this block of code into a newly named script, but call it from this script.
There was a problem hiding this comment.
My feeling was that would need a lot of careful checking to keep things between score_kaldi.sh and score_kaldi_cer.sh, as it relies on a couple of the variables being set and the files being created and so on. I think I'll close it (for now).
|
@danpovey how about this. Do not merge yet --even if you ACK this, as I want to test it, there might be typos. |
|
Looks reasonable |
|
Tested on HKUST and it works, including the to proposed solution for combined CER and WER scoring (via the parameter forwarding). |
|
I just remembered you want me to move the scripts somewhere -- let me know where, as I've already forgot :-/ |
|
steps/scoring/. On Tue, Nov 8, 2016 at 11:06 AM, jtrmal notifications@github.com wrote:
|
84f6402 to
f079592
Compare
f079592 to
31add26
Compare
|
OK, moved, symlinked, rebased&squashed |
|
Thanks! Merging. |
Working on one of the Mandarin chinese recipes.
Need CER scoring for these purposes.