Skip to content

adding CER scoring capability#1174

Merged
danpovey merged 2 commits intokaldi-asr:masterfrom
jtrmal:score_kaldi_ext
Nov 8, 2016
Merged

adding CER scoring capability#1174
danpovey merged 2 commits intokaldi-asr:masterfrom
jtrmal:score_kaldi_ext

Conversation

@jtrmal
Copy link
Contributor

@jtrmal jtrmal commented Nov 4, 2016

Working on one of the Mandarin chinese recipes.
Need CER scoring for these purposes.

@jtrmal
Copy link
Contributor Author

jtrmal commented Nov 4, 2016

Tested on HKUST

fi
fi

if $cer && [ $stage -le 2 ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a special case, I don't like having such a big block.
How about calling steps/scoring/score_kaldi_cer.sh, and moving steps/score_kaldi.sh to steps/scoring/ and making it a link? [trying to move to subdirs in steps/]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean move this block of code into a newly named script, but call it from this script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling was that would need a lot of careful checking to keep things between score_kaldi.sh and score_kaldi_cer.sh, as it relies on a couple of the variables being set and the files being created and so on. I think I'll close it (for now).

@jtrmal jtrmal closed this Nov 7, 2016
@jtrmal jtrmal reopened this Nov 7, 2016
@jtrmal jtrmal changed the title adding CER scoring capability WIP: adding CER scoring capability Nov 7, 2016
@jtrmal
Copy link
Contributor Author

jtrmal commented Nov 7, 2016

@danpovey how about this.
I tried to make each script working on its own, yet support combination of those two in an auxiliary local/score.sh, that would just forward the parameters.

Do not merge yet --even if you ACK this, as I want to test it, there might be typos.

@danpovey
Copy link
Contributor

danpovey commented Nov 7, 2016

Looks reasonable

@jtrmal
Copy link
Contributor Author

jtrmal commented Nov 8, 2016

Tested on HKUST and it works, including the to proposed solution for combined CER and WER scoring (via the parameter forwarding).
y.

@jtrmal jtrmal changed the title WIP: adding CER scoring capability adding CER scoring capability Nov 8, 2016
@jtrmal
Copy link
Contributor Author

jtrmal commented Nov 8, 2016

I just remembered you want me to move the scripts somewhere -- let me know where, as I've already forgot :-/

@danpovey
Copy link
Contributor

danpovey commented Nov 8, 2016

steps/scoring/.

On Tue, Nov 8, 2016 at 11:06 AM, jtrmal notifications@github.com wrote:

I just remembered you want me to move the scripts somewhere -- let me know
where, as I've already forgot :-/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1174 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADJVu1k0f3FqMtqVBFcPykpq_BhgS8Rjks5q8J4RgaJpZM4Kp98t
.

@jtrmal
Copy link
Contributor Author

jtrmal commented Nov 8, 2016

OK, moved, symlinked, rebased&squashed

@danpovey
Copy link
Contributor

danpovey commented Nov 8, 2016

Thanks! Merging.

@danpovey danpovey merged commit 0de048e into kaldi-asr:master Nov 8, 2016
@jtrmal jtrmal deleted the score_kaldi_ext branch February 10, 2017 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants