Skip to content

SendMail: Fixed function calls & redundant def #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 1 commit into from
Oct 31, 2016
Merged

SendMail: Fixed function calls & redundant def #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions egs/wsj/s5/steps/nnet3/train_dnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ def Train(args, run_opts):
[report, times, data] = nnet3_log_parse.GenerateAccuracyReport(args.dir)
message = report
subject = "Update : Expt {dir} : Iter {iter}".format(dir = args.dir, iter = iter)
sendMail(message, subject, args.email)
SendMail(message, subject, args.email)

num_archives_processed = num_archives_processed + current_num_jobs

Expand Down Expand Up @@ -646,7 +646,7 @@ def Main():
except Exception as e:
if args.email is not None:
message = "Training session for experiment {dir} died due to an error.".format(dir = args.dir)
sendMail(message, message, args.email)
SendMail(message, message, args.email)
traceback.print_exc()
raise e

Expand Down
16 changes: 3 additions & 13 deletions egs/wsj/s5/steps/nnet3/train_rnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ def Train(args, run_opts):
[report, times, data] = nnet3_log_parse.GenerateAccuracyReport(args.dir)
message = report
subject = "Update : Expt {dir} : Iter {iter}".format(dir = args.dir, iter = iter)
sendMail(message, subject, args.email)
SendMail(message, subject, args.email)

num_archives_processed = num_archives_processed + current_num_jobs

Expand Down Expand Up @@ -724,7 +724,7 @@ def Train(args, run_opts):
# do some reporting
[report, times, data] = nnet3_log_parse.GenerateAccuracyReport(args.dir)
if args.email is not None:
sendMail(report, "Update : Expt {0} : complete".format(args.dir), args.email)
SendMail(report, "Update : Expt {0} : complete".format(args.dir), args.email)

report_handle = open("{dir}/accuracy.report".format(dir = args.dir), "w")
report_handle.write(report)
Expand All @@ -740,19 +740,9 @@ def Main():
except Exception as e:
if args.email is not None:
message = "Training session for experiment {dir} died due to an error.".format(dir = args.dir)
sendMail(message, message, args.email)
SendMail(message, message, args.email)
traceback.print_exc()
raise e

def SendMail(message, subject, email_id):
try:
subprocess.Popen('echo "{message}" | mail -s "{subject}" {email} '.format(
message = message,
subject = subject,
email = email_id), shell=True)
except Exception as e:
logger.info(" Unable to send mail due to error:\n {error}".format(error = str(e)))
pass

if __name__ == "__main__":
Main()