Fix get_ctm_edits.py to be not too greedy with id's#1154
Merged
danpovey merged 1 commit intokaldi-asr:masterfrom Oct 29, 2016
Merged
Fix get_ctm_edits.py to be not too greedy with id's#1154danpovey merged 1 commit intokaldi-asr:masterfrom
danpovey merged 1 commit intokaldi-asr:masterfrom
Conversation
Contributor
|
Probably OK, but let me wait till we find out why the nbest-to-ctm thing was failing. |
a) Fix get_ctm_edits.py to be not too greedy with id's. It would go wrong if an id was a prefix of another id b) Add lattice-1best command in ctm generation for the non-position-dependent-phones case
Contributor
Author
|
@danpovey Updated to include the lattice-1best fix |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not too pretty this way (and possibly wasteful), but the whole function would need reorganization to do this in a nicer way. (See also email thread "Problems with cleanup, can't align in get_ctm_edits.py")