Fix the gawk-specific feature problems in prepare dict scripts.#1147
Merged
danpovey merged 4 commits intokaldi-asr:masterfrom Oct 27, 2016
jinyiyang-jhu:dev-scripts
Merged
Fix the gawk-specific feature problems in prepare dict scripts.#1147danpovey merged 4 commits intokaldi-asr:masterfrom jinyiyang-jhu:dev-scripts
danpovey merged 4 commits intokaldi-asr:masterfrom
jinyiyang-jhu:dev-scripts
Conversation
jinyiyang-jhu
changed the title
danpovey
reviewed
Oct 27, 2016
Contributor
danpovey
left a comment
danpovey
left a comment
There was a problem hiding this comment.
some lower/upper-case disagreements
| @@ -117,10 +117,7 @@ patch <local/dict.patch $dir/lexicon0.txt || exit 1; | |||
|
|
|||
| #(2a) Dictionary preparation: | |||
| # Pre-processing (Upper-case, remove comments) | |||
Contributor
There was a problem hiding this comment.
Plese remove the 'Upper-case' comment here since it's not being done.
| $srcdict | sort | awk '($0 !~ /^[:space:]*$/) {print}' \ | ||
| > $dir/lexicon1.txt || exit 1; | ||
|
|
||
| grep -v '^#' $srcdict | tr '[a-z]' '[A-Z]' | awk 'NF>0' | sort > $dir/lexicon1.txt || exit 1; |
Contributor
There was a problem hiding this comment.
The comment said 'Upper-case' but the code was actually lower-casing. So please lower-case instead, and change the comment. See if there are similar issues elsewhere.
Contributor
|
OK, but please change the comments so that they correspond to what is actually being done w.r.t. casing. All comments say 'upper-case', but some do lower, some do nothing. |
Contributor
Author
|
Done! |
Contributor
|
Thanks! Merging. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the gawk-specific feature problems in prepare dict scripts.
Described here: #1143