Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more possibility for validation of password #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tburguie
Copy link

Add possibility to check for a certain number of lower, punctuation
characters and a number of rule to check among min_lower, min_upper,
min_digit, min_punct.

Add possibility to check for a certain number of lower, punctuation
characters and a number of rule to check among min_lower, min_upper,
min_digit, min_punct.
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 5b28b68 on tburguie:master into 245bafb on kakwa:master.

@kakwa
Copy link
Owner

kakwa commented Feb 13, 2019

Hummm,

the ppolicy simple is meant to be... simple, I think it would be a better feat for a more complex ppolicy module such as:

https://github.com/kakwa/ldapcherry-ppolicy-cracklib/blob/master/lcppolicy_cracklib/__init__.py

Also, setting default value might be a good idea:

self.get_param('min_point')

self.get_param('min_point', 0)

Otherwise it will introduce a breaking change in the configuration format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants