Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of top/bottom bars broken #520

Closed
moomop opened this issue Sep 19, 2021 · 1 comment · Fixed by #527
Closed

Behavior of top/bottom bars broken #520

moomop opened this issue Sep 19, 2021 · 1 comment · Fixed by #527
Labels
bug Something isn't working
Milestone

Comments

@moomop
Copy link

moomop commented Sep 19, 2021

Configuration

  • Operating system with its version: Ubuntu 20.04
  • Browser with its version: Firefox Version 92.0 (64-bit) (also visible on other browsers)
  • Hugo version: hugo v0.84.1-4BD65E22+extended linux/amd64 BuildDate=2021-06-24T11:44:23Z VendorInfo=gohugoio
  • Tranquilpeak version: 0.5.2-BETA
  • Do you reproduce on https://tranquilpeak.kakawait.com demo?: Yes

Actual behavior

Pages such as https://tranquilpeak.kakawait.com/2015/05/elements-showcase/ now always show the bar at the top and do not show the bar at the bottom (regardless of scrolling).

Expected behavior

The bars at top and bottom should disappear when scrolling down and reappear when scrolling up. (That is the behavior of the hexo theme)
This behavior appears to have changed with the following commit:
039f737 Revamp sidebar translation

Steps to reproduce the behavior

The change in behavior can be seen in the example site.

cd exampleSite
hugo server --themesDir ../../
@kakawait kakawait added the bug Something isn't working label Sep 19, 2021
@kakawait kakawait reopened this Sep 19, 2021
@kakawait kakawait added this to the 0.5.3-BETA milestone Sep 19, 2021
@kakawait
Copy link
Owner

I've found problem. I'll push fix this weekend

kakawait added a commit that referenced this issue Oct 2, 2021
kakawait added a commit that referenced this issue Oct 4, 2021
riton pushed a commit to riton/hugo-tranquilpeak-theme that referenced this issue Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants