author.picture and params.coverImage from config.yml don't behave the same way

[xenlo]

Hi/Bonjour,

I'm new with Hugo, so I'm not sure that this is a bug. At least the theme configuration, didn't behave the way I expected.

Configuration

• hugo-tranquilpeak-theme 0.4.4-BETA
• hugo v0.37.1 linux/amd64

Actual behavior

Parameters author.picture and params.coverImage from config.yml don't behave the same way.

I put both picture and coverImage files into ~/HugoProject/static/images/theme/. After building my site, both jpeg files end well in ~/HugoProject/public/images/theme/. But the html generated give:

• http://example.org/images/theme/logo.jpg for picture, and
• http://nolwenn.be/images/images/images/theme/cover_01.jpg for my coverImage

baseURL: "http://example.org/"
[...]
author:
[...]
    picture:  "/images/theme/logo.jpg"
params:
[...]
    coverImage:  "/images/theme/cover_01.jpg"
[...]

A workaround is possible but tweaking the path only for coverImage like this:

    coverImage:  "/theme/cover_01.jpg"

Expected behavior

Images/files that we put at the same static place, and that end under the same path once generated should be referenced the same way in the config file.

Steps to reproduce the behavior

1. Create a fresh Huge project
2. Add the tranquilpeak-theme in it,
3. Copy you Avatar/logo picture and background picture in the same directory somewhere under /static
4. Edit your config.yml/tml to set picture and params.coverImage to point to the corresponding file (both having the same path)
5. Generate you static site

[xenlo]

I dig a bit. I found that in certain files like themes/tranquilpeak/layouts/partials/meta.html, .Params.coverImageand .Author.picture are used the same way though absURL filter.

xenlo@silver-screen:~/Scripts/hugolwenn$ grep ".Params.coverImage\|.Author.picture" -C5 themes/tranquilpeak/layouts/partials/meta.html

{{ with .Params.thumbnailImage }}
  <meta property="og:image" content="{{ . | absURL }}">
  <meta property="twitter:image" content="{{ . | absURL }}">
{{ end }}
{{ with .Params.coverImage }}
  <meta property="og:image" content="{{ . | absURL }}">
  <meta property="twitter:image" content="{{ . | absURL }}">
{{ end }}
{{ with .Params.gallery }}
  {{ range . }}
--
{{ end }}

{{ if .Scratch.Get "gravatarEmail" }}
  <meta property="og:image" content="https://www.gravatar.com/avatar/{{ (md5 (.Scratch.Get "gravatarEmail")) | urlize }}?s=640">
  <meta property="twitter:image" content="https://www.gravatar.com/avatar/{{ (md5 (.Scratch.Get "gravatarEmail")) | urlize }}?s=640">
{{ else if .Site.Author.picture }}
  <meta property="og:image" content="{{ .Site.Author.picture | absURL }}">
  <meta property="twitter:image" content="{{ .Site.Author.picture | absURL }}">
{{ end }}

Nevertheless, in themes/tranquilpeak/layouts/partials/cover.html it adds an imges/ if the coverImage don't contain a ://.

{{ with .Site.Params.coverImage }}
  {{ if (in . "://") }}
    {{ $cover := . }}
    <div id="cover" style="background-image:url('{{ $cover | absURL }}');"></div>
  {{ else }}
    {{ $cover := (printf "images/%s" .) }}
    <div id="cover" style="background-image:url('{{ $cover | absURL }}');"></div>
  {{ end }}
{{ end }}