Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate google analytics #21

Closed
kakawait opened this issue Nov 13, 2016 · 0 comments · Fixed by #23
Closed

Migrate google analytics #21

kakawait opened this issue Nov 13, 2016 · 0 comments · Fixed by #23
Assignees
@kakawait
Labels
breaking changes enhancement New feature or request
Milestone
0.1.1-ALPHA

Comments

@kakawait
Copy link
Owner

Related to LouisBarranqueiro/hexo-theme-tranquilpeak#361 ga.js is deprecated.

I also want to use Hugo common key configuration googleAnalytics (https://gohugo.io/extras/analytics/) instead of custom one Params.google_analytics_id

That will break changes, user must migrate from

[params]
  google_analytics_id = ...

to

googleAnalytics = ...

Moreover I will delete google-analytics.html in favor of built-in internal template (async) one.
@kakawait kakawait added the enhancement New feature or request label Nov 13, 2016
@kakawait kakawait added this to the 0.2.0-ALPHA milestone Nov 13, 2016
@kakawait kakawait self-assigned this Nov 13, 2016
@kakawait kakawait modified the milestones: 0.1.1-ALPHA, 0.2.0-ALPHA Nov 13, 2016
kakawait added a commit that referenced this issue Nov 13, 2016
@kakawait
Migrate old GA script to new
b322de9 
- Upgrade *Google Analytics* script to do not use anymore `ga.js` which is now deprecated
- Changes *Google Analytics* config key from `params.google_analytics_id` to official `googleAnalytics`
- Add parameter to choose between sync/async loading of *Google Analytics* `params.ga.async`
- Create migration 0.1.0-ALPHA -> 0.1.1-ALPHA

fixes #21
@kakawait kakawait mentioned this issue Nov 13, 2016
Merged
zacbook pushed a commit to zacbook/hugo-tranquilpeak-theme that referenced this issue Nov 12, 2017
@kakawait
Migrate old GA script to new
719b256 
- Upgrade *Google Analytics* script to do not use anymore `ga.js` which is now deprecated
- Changes *Google Analytics* config key from `params.google_analytics_id` to official `googleAnalytics`
- Add parameter to choose between sync/async loading of *Google Analytics* `params.ga.async`
- Create migration 0.1.0-ALPHA -> 0.1.1-ALPHA

fixes kakawait#21
Data-Think-2021 pushed a commit to Data-Think-2021/hugo-tranquilpeak-theme that referenced this issue Feb 19, 2023
@kakawait
Migrate old GA script to new
75df39e 
- Upgrade *Google Analytics* script to do not use anymore `ga.js` which is now deprecated
- Changes *Google Analytics* config key from `params.google_analytics_id` to official `googleAnalytics`
- Add parameter to choose between sync/async loading of *Google Analytics* `params.ga.async`
- Create migration 0.1.0-ALPHA -> 0.1.1-ALPHA

fixes kakawait#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kakawait kakawait

Labels
breaking changes enhancement New feature or request
Projects
None yet
Milestone
0.1.1-ALPHA
Development

Successfully merging a pull request may close this issue.

Migrate old GA script to new kakawait/hugo-tranquilpeak-theme
1 participant
@kakawait