Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme version on meta as same as hugo version #140

Closed
kakawait opened this issue Apr 12, 2017 · 4 comments
Closed

Add theme version on meta as same as hugo version #140

kakawait opened this issue Apr 12, 2017 · 4 comments
Assignees
@kakawait
Milestone
0.4.0-BETA

Comments

@kakawait
Copy link
Owner

as same as

<meta name="generator" content="Hugo 0.19">

I think it can be a good option to add also theme version like

<meta name="theme" content="Tranquilpeak 0.3.1-BETA">
@kakawait kakawait added the enhancement New feature or request label Apr 12, 2017
@kakawait kakawait added this to the 0.3.1-BETA milestone Apr 12, 2017
@kakawait kakawait self-assigned this Apr 12, 2017
@kakawait kakawait added feature request and removed enhancement New feature or request labels Apr 15, 2017
@kakawait kakawait mentioned this issue Apr 15, 2017
Merged
@ghost
Copy link

ghost commented Apr 15, 2017

That's actually not a valid meta tag. http://devdocs.io/html/element/meta

@ghost
Copy link

ghost commented Apr 15, 2017

I think what you want to do is override the generator meta tag with additional information.

@kakawait
Copy link
Owner Author

Nice catch. I didn't know there was a list of meta

@kakawait kakawait reopened this Apr 15, 2017
@kakawait kakawait modified the milestones: 0.4.0-BETA, 0.3.1-BETA Apr 15, 2017
@ghost
Copy link

ghost commented Apr 15, 2017

No problemo. Devdocs is open source, offline capable and pulls data from trusted sources like MDN. Use it like it's going out of style.

@kakawait kakawait mentioned this issue Apr 17, 2017
Merged
zacbook pushed a commit to zacbook/hugo-tranquilpeak-theme that referenced this issue Nov 12, 2017
@kakawait
Add theme version on meta tag
b75439d 
closes kakawait#140
zacbook pushed a commit to zacbook/hugo-tranquilpeak-theme that referenced this issue Nov 12, 2017
@kakawait
Add theme version on generator rather than custom
2199087 
closes kakawait#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kakawait kakawait

Labels
None yet
Projects
None yet
Milestone
0.4.0-BETA
Development

No branches or pull requests
1 participant
@kakawait