-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panick in planifolia sqrt #98
Comments
Looking at the error, I guess this is a case I've kind of known about for a while but not gotten around to fix: numbers in rsass can be isize rational, bignum rational or f64, but there is not enough conversions in place to handle case like this. If I try So, this should be fixed. In the mean time, if you need a sqrt function, rsass impllements the sass:math sqrt function. The following sass code gives the expected output (in 0.00s): @use "sass:math" as *;
$x: sqrt(2);
a { size: $x } |
Thanks for your suggestion. Using the builtin $x: 1.4142135623;
a { size: $x * $x } |
Progress: 3371 of 5945 tests passed in dart-sass compatibility mode. ### Breaking changes * The unit of a `Numeric` is now a `UnitSet` rather than a `Unit`. * `Error` has new variants and a new field in `BadArguments`. * A sass::Value::Call now has a source position. * A `Rational` is now a `Ratio<i64>` rather than a `Ratio<isize>`. ### Improvements * Added a Contributing section to readme. * Handle values with multiple units. PR #97. * Show call position for errors in function calls, and test for type errors in many standard functions. Many error messages are made identical to dart-sass, improving test-suit progress with more than 400 tests. PR #99. * Fix issue #98: overflow in rational number arithmetic. * Allow `@at-root` at document root. * Boolean operators is truly lazy, e.g. `false and f($x)` does not call `f`. * Refactored number parsing to use overflowing rationals. PR #100. * Test suite sass-spec updated to 2021-03-02. * Updated num-rational and num-bigint to 0.4.0. Thanks to @alvra for reporting #98. Tested with rustc 1.50.0 (cb75ad5db 2021-02-10), rustc 1.48.0 (7eac88abb 2020-11-16), rustc 1.46.0 (04488afe3 2020-08-24), rustc 1.44.1 (c7087fe00 2020-06-17), rustc 1.51.0-beta.6 (6a1835ad7 2021-03-12), and rustc 1.52.0-nightly (acca81892 2021-03-13).
When using the math functions from planifolia, I'm getting a panic computing a sqrt.
Example:
https://github.com/xi/sass-planifolia/blob/master/sass/math.scss
The text was updated successfully, but these errors were encountered: