Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ Method: PcapHandle.sendPacket(final byte[] bytes, final int len) #89

Merged
merged 1 commit into from
Mar 7, 2017
Merged

+ Method: PcapHandle.sendPacket(final byte[] bytes, final int len) #89

merged 1 commit into from
Mar 7, 2017

Conversation

betschwa
Copy link

@betschwa betschwa commented Mar 2, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 70.229% when pulling 277d546 on betschwa:v1 into c301599 on kaitoy:v1.

@kaitoy
Copy link
Owner

kaitoy commented Mar 2, 2017

Is this new method really needed or useful?
What is the usecase?

@betschwa
Copy link
Author

betschwa commented Mar 3, 2017

Yes, it is.
I need to send large amount of packages (currently > 500.000/s) and with this method I don't need to create a new byte array for each package. I can re-use the old one.

@kaitoy kaitoy merged commit 277d546 into kaitoy:v1 Mar 7, 2017
@kaitoy
Copy link
Owner

kaitoy commented Mar 7, 2017

Thank you for your contribution.
I merged it.

@betschwa
Copy link
Author

betschwa commented Mar 8, 2017

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitoy kaitoy kaitoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betschwa @coveralls @kaitoy