Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DLT_RAW, and make the Unit Tests work for non-root users #23

Merged
merged 2 commits into from
Sep 20, 2014

Conversation

pjsg
Copy link
Contributor

@pjsg pjsg commented Sep 19, 2014

There are two commits:

  1. Add support for DLT_RAW so that you can read a pcap file which just has raw IP packets.

  2. Fix the unit tests so that they run for users without root privilege.

Thanks

kaitoy added a commit that referenced this pull request Sep 20, 2014
Thank you. I merge these 2 commits. But I need to add some changes for DLT_RAW on OpenBSD and the properties-based packet factory.
@kaitoy kaitoy merged commit 153ecf6 into kaitoy:master Sep 20, 2014
@kaitoy
Copy link
Owner

kaitoy commented Sep 20, 2014

Thank you. I merged the 2 commits. But I need to add some more changes for DLT_RAW on OpenBSD and the properties-based packet factory.

@pjsg
Copy link
Contributor Author

pjsg commented Sep 20, 2014

Thanks for that.

In my testing I have another issue. The exception IllegalRawDataException
can be thrown when constructing packets. This exception is not declared as
being thrown from GetNextPacketEx().

I'm not sure of the best way to deal with this.

I filed another pull request that deals with a crash when building a TCP
header from bad data.

Philip

On Sat, Sep 20, 2014 at 7:18 PM, Kaito Yamada [email protected]
wrote:

Thank you. I merged the 2 commits. But I need to add some more changes for
DLT_RAW on OpenBSD and the properties-based packet factory.


Reply to this email directly or view it on GitHub
#23 (comment).

@kaitoy
Copy link
Owner

kaitoy commented Sep 21, 2014

It is expected behavior that IllegalRawDataException can be thrown during building packet objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants