-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.cfg: add metadata.project_urls
#71
Conversation
Fix #69 According to a project example https://pypi.org/project/PyScaffold/4.3/ + https://github.com/pyscaffold/pyscaffold/blob/v4.3/setup.cfg#L7-L15, the "Homepage" link pulled from `metadata.url` apparently stays even if I add `project_urls`, so all links at PyPI resulting from this change should be (I'm not sure about their order, but again links on https://pypi.org/project/PyScaffold/4.3/ seem to be sorted alphabetically except the implicit "Homepage" link at the beginning): - [Homepage](https://kaitai.io) - [Gitter](https://gitter.im/kaitai_struct/Lobby) - [Source](https://github.com/kaitai-io/kaitai_struct_python_runtime) - [Tracker](https://github.com/kaitai-io/kaitai_struct_python_runtime/issues) - [Twitter](https://twitter.com/kaitai_io) Currently (see https://pypi.org/project/kaitaistruct/0.10/) the project links are just: - [Homepage](https://kaitai.io)
IMHO it'd be a bit redundant to add the links |
Also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of links looks good to me. I personally wouldn't have added a Twitter link here (I think it's not all that relevant when coming from PyPI), but I have no problem with keeping it if the list doesn't become too long.
A link to the docs sounds good, but I have no strong opinion about linking to the main docs or the Python notes (the reader can always click through to the other docs if needed).
From where do you have that information? The setuptools docs for
That's still not an option. As before, In any case, switching to a different configuration format is off-topic for this PR. |
I agree that it's not that relevant for the Python runtime, and it's not clear what a Python user would find there. |
That's true, so I think the main docs are fine. |
Fix #69
According to a project example https://pypi.org/project/PyScaffold/4.3/ + https://github.com/pyscaffold/pyscaffold/blob/v4.3/setup.cfg#L7-L15, the "Homepage" link pulled from
metadata.url
apparently stays even if I addproject_urls
, so all links at PyPI resulting from this change should be (I'm not sure about their order, but again links on https://pypi.org/project/PyScaffold/4.3/ seem to be sorted alphabetically except the implicit "Homepage" link at the beginning):Currently (see https://pypi.org/project/kaitaistruct/0.10/) the project links are just: