Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to group name. #66

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

yuuu
Copy link
Contributor

@yuuu yuuu commented Jan 11, 2020

I found an issue where adding a group without a name made it impossible to open '/ application_settings/user_managements'.

So I am fixing the following 4 points.

  1. Group name is required
  2. Change the rendering destination at validation error from edit to index
  3. Set @groups when creating
  4. Change 'group' in index.html.erb to '@group'

@kaishuu0123 kaishuu0123 merged commit c58cd29 into kaishuu0123:master Jan 14, 2020
@kaishuu0123 kaishuu0123 mentioned this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants