Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GeneralizedDiceScore by DiceScore & fix class-wise metrics #719

Merged
merged 18 commits into from
Dec 9, 2024
Merged

Replace GeneralizedDiceScore by DiceScore & fix class-wise metrics #719

merged 18 commits into from
Dec 9, 2024

Conversation

nkaenzig
Copy link
Collaborator

@nkaenzig nkaenzig commented Nov 28, 2024 •
edited
Loading

Closes #718

Used DiceMetric from MONAI for class-wise scores, because in torchmetrics there is an open issue for this:
Lightning-AI/torchmetrics#2851

@nkaenzig nkaenzig linked an issue Nov 28, 2024 that may be closed by this pull request
Fix classwise dice metrics #718
Closed
@nkaenzig nkaenzig self-assigned this Nov 28, 2024
@nkaenzig nkaenzig marked this pull request as ready for review November 28, 2024 15:23
@nkaenzig nkaenzig marked this pull request as draft November 28, 2024 15:55
@nkaenzig nkaenzig changed the title Update torchmetrics and replace GeneralizedDiceScore by DiceScore Replace GeneralizedDiceScore by DiceScore & fix class-wise metrics Nov 29, 2024
@nkaenzig nkaenzig marked this pull request as ready for review November 29, 2024 12:47
roman807
roman807 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@roman807 roman807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe @ioangatop should have a look as well here

@nkaenzig nkaenzig enabled auto-merge (squash) December 9, 2024 09:05
@nkaenzig nkaenzig merged commit 453a12e into main Dec 9, 2024
6 checks passed
@nkaenzig nkaenzig deleted the 718-fix-classwise-dice-metrics branch December 9, 2024 09:07
@nkaenzig nkaenzig mentioned this pull request Dec 10, 2024
Draft
This was referenced Dec 23, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman807 roman807 roman807 approved these changes

@ioangatop ioangatop Awaiting requested review from ioangatop

Assignees

@nkaenzig nkaenzig

Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix classwise dice metrics
2 participants
@nkaenzig @roman807