Skip to content

node/cn/filters: Check filter GetLogs args correctly and add test cases#499

Merged
2dvorak merged 1 commit intokaiachain:feat/v2.1.0from
2dvorak:filter-getlogs-argcheck
Aug 12, 2025
Merged

node/cn/filters: Check filter GetLogs args correctly and add test cases#499
2dvorak merged 1 commit intokaiachain:feat/v2.1.0from
2dvorak:filter-getlogs-argcheck

Conversation

@2dvorak
Copy link
Copy Markdown
Contributor

@2dvorak 2dvorak commented Aug 7, 2025

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@2dvorak 2dvorak self-assigned this Aug 7, 2025
@2dvorak 2dvorak changed the title Check filter GetLogs args correctly and add test cases node/cn/filters: Check filter GetLogs args correctly and add test cases Aug 7, 2025
@2dvorak 2dvorak marked this pull request as ready for review August 7, 2025 13:56
@blukat29 blukat29 added the do not merge Do not merge just yet label Aug 7, 2025
blukat29
blukat29 previously approved these changes Aug 8, 2025
@blukat29 blukat29 changed the base branch from dev to feat/v2.1.0 August 8, 2025 04:47
@blukat29 blukat29 dismissed their stale review August 8, 2025 04:47

The base branch was changed.

@blukat29 blukat29 removed the do not merge Do not merge just yet label Aug 8, 2025
@2dvorak 2dvorak merged commit dd5ed5a into kaiachain:feat/v2.1.0 Aug 12, 2025
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants