Skip to content

txpool: Accept transaction from new sender with better price#391

Merged
tnasu merged 3 commits into
kaiachain:devfrom
tnasu:dev-pool
Jun 10, 2025
Merged

txpool: Accept transaction from new sender with better price#391
tnasu merged 3 commits into
kaiachain:devfrom
tnasu:dev-pool

Conversation

@tnasu
Copy link
Copy Markdown
Contributor

@tnasu tnasu commented May 26, 2025

Proposed changes

Change behavior when the TxPool capacity is exceeded (from the LegacyPool of Geth)

And, TxPool priced heap treats only remote for dropping/discarding under price tx without distinction between local/remote(Remove local from TxPool priced heap)
Ref: https://github.com/ethereum/go-ethereum/pull/21478/files

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@tnasu tnasu self-assigned this May 26, 2025
@tnasu tnasu marked this pull request as ready for review May 26, 2025 06:30
Comment thread blockchain/tx_pool.go
Comment thread blockchain/tx_pool.go
Comment thread blockchain/tx_list.go
@tnasu
Copy link
Copy Markdown
Contributor Author

tnasu commented Jun 3, 2025

@hyeonLewis @yoomee1313 I considered your feedback, and I removed local from TxPool priced heap. Please review it again. Thanks.

@tnasu
Copy link
Copy Markdown
Contributor Author

tnasu commented Jun 5, 2025

@hyeonLewis, @yoomee1313, I reconsidered that my additional commit has side effects. At this time, I focused on maintaining local consistency.

Co-authored-by: yumiel yoomee1313 <yumiel.ko@kaia.io>
@blukat29 blukat29 added do not merge Do not merge just yet and removed do not merge Do not merge just yet labels Jun 6, 2025
@tnasu tnasu merged commit 80192e1 into kaiachain:dev Jun 10, 2025
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 10, 2025
@tnasu tnasu deleted the dev-pool branch June 26, 2025 01:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants