switch JLL #14
Merged
switch JLL #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I assume most users have moved to Julia 1.3 and we can point to v0.1.0 for older use cases. Also, I admittedly haven't migrated my stuff to GH actions. I assume we need to merge your changes to run these on the main repo? |
|
@jalving yes, I think I can submit another PR to fix things if test is broken (but I think it's fine), I added 1.0 in CI, we can check if that that fails or not. |
|
Apparently it takes some work to support jll packages on Julia 1.0-1.2 (see the comments in https://github.com/JuliaBinaryWrappers/KaHyPar_jll.jl/blob/master/src/KaHyPar_jll.jl). I'm honestly ok with just requiring Julia 1.3. We can remove the 1.0 CI actions and I can cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7 fix #12 (Maybe should file a seperaete issue for Windows and other platform)
the MacOS should be fixed by this PR, please enable the github action so that I can run the tests in CI.