Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal parent once child takes over #763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mechanicker
Copy link

@mechanicker mechanicker commented Jun 25, 2023

Fix for: #230

Parent process was blocked waiting on wg sync.WaitGroup preventing autofs from managing the forked daemon child process. Sending the signal to parent once child is ready ensures parent process exits and lets child process handle mounting and serving FUSE requests.

Tested this in an EC2 instance with existing autofs (for NFS) with goofys:

$ cat /etc/auto.master
/mnt/data  /etc/auto.nfs
/mnt/data/s3  /etc/auto.s3

$ cat /etc/auto.s3
data -fstype=fuse,_netdev,allow_other,--region=us-west-2 :goofys#s3-bucket-name

# List contents of git repository in S3 bucket
$ ls /mnt/data/s3/data/repos/puntar/
HEAD  config  description  hooks  info  objects  packed-refs

@mechanicker mechanicker changed the title Daemon: Signal parent once child takes over #230: Signal parent once child takes over Jun 25, 2023
@mechanicker mechanicker changed the title #230: Signal parent once child takes over Signal parent once child takes over Jun 25, 2023
@mechanicker mechanicker changed the title Signal parent once child takes over Fix #230: Signal parent once child takes over Jun 25, 2023
@mechanicker mechanicker changed the title Fix #230: Signal parent once child takes over Signal parent once child takes over Jun 25, 2023
@mechanicker
Copy link
Author

@kahing Could you please help review and merge this important fix to get goofys working with automounter/autofs?

@mechanicker mechanicker force-pushed the dhruva/autofs-daemon branch 2 times, most recently from abb64fa to 1b67254 Compare June 26, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant