Add GetFullName() back #558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kahing i'm not able to add you as a "Reviewer" or "Assignee". LMK how you'd like to proceed |
|
It looks like it was removed here: e636495 although i'm not sure what the reasoning was? |
|
@bensussman goofyscache sounds interesting -- can you publish this somewhere? |
|
@gaul I think that can be arranged! It currently is a submodule in spell's proprietary "API" but as part of this project I have been meaning to make it its own go module, and pull it into its own git repo. I'll work on it in the coming months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively the same PR as #330 which was merged back in 2018 and allowed us at Spell to wrap
goofysinto agoofyscachelibrary that solves our specific use cases thatcatfsdoes not.We are currently live on an old version of goofys, but would like to take advantage of the recently added Azure support and in order to upgrade we need the
GetFullName()method to be added back.Thanks!