Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text colors #3

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

gsalinas
Copy link

Removed the colors from the Base.show() implementation for ModbusContexts so they display properly regardless of terminal color schemes, usage in logs, etc.

Thanks!

@kagalenko-m-b
Copy link
Owner

kagalenko-m-b commented May 31, 2023

The test fails when run in github cloud. I was unable to determine the reason. It passed when unit_test_client.jl had been run against unit-test-server from libmobus. Fixing this would be quite helpful, but if you can't figure out what is going on, probably best to leave it unchanged by this PR.

and leaving it broken.

This reverts commit 5e961f4.
@gsalinas
Copy link
Author

Gotcha! Unfortunate. I've reverted the change to the test for now.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.46 🎉

Comparison is base (e66cbb3) 76.06% compared to head (95e476d) 76.52%.

❗ Current head 95e476d differs from pull request most recent head 69d82a3. Consider uploading reports for the commit 69d82a3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   76.06%   76.52%   +0.46%     
==========================================
  Files           1        1              
  Lines         330      328       -2     
==========================================
  Hits          251      251              
+ Misses         79       77       -2     
Impacted Files Coverage Δ
src/LibModbus.jl 76.52% <0.00%> (+0.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

No need to use `printstyled()` after disabling color change.
@kagalenko-m-b kagalenko-m-b merged commit 8836bdf into kagalenko-m-b:master Jun 1, 2023
@kagalenko-m-b
Copy link
Owner

Thanks, merged the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TcpContexts don't properly implement Base.show
2 participants