This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Update tsconfig with last tsconfig/base and node20 era #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Jul 13, 2023
| interface App { | ||
| ports: Ports; | ||
| } | ||
| declare module '*.elm' { |
There was a problem hiding this comment.
- Needed since "type": "module",
- https://discourse.elm-lang.org/t/how-to-use-elm-in-tsx-file/4556/3
|
Visit the preview URL for this PR (updated for commit d4a6785): https://mobu-elm--pr370-update-tsconfig-ensmxqc4.web.app (expires Thu, 20 Jul 2023 04:59:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c3bd1c7e660dfd047316b813d1455fa3121557d6 |
kachick
commented
Jul 13, 2023
| @@ -1,5 +1,5 @@ | |||
| import { defineConfig, loadEnv } from 'vite'; | |||
| import elmPlugin from 'vite-plugin-elm'; | |||
| import { plugin } from 'vite-plugin-elm'; | |||
There was a problem hiding this comment.
- Needed since "type": "module",
kachick
commented
Jul 13, 2023
| "compilerOptions": { | ||
| "lib": ["ESNext", "DOM"], | ||
| "lib": ["dom", "dom.iterable"], |
There was a problem hiding this comment.
- Passed transpile without this change, but updated with referring https://github.com/tsconfig/bases/blob/014e8927b7155640f65a7492fb4bb09f5c49f531/bases/create-react-app.json#L7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #367