KAA-1423: Add Endpoint Specific Configuration Support. #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 15, 2016 13:11
vtkhir
suggested changes
Dec 15, 2016
| @@ -61,7 +60,7 @@ public void testFindByEndpointKeyHashAndConfigurationVersion() throws Exception | |||
| Assert.assertNull(found4); | |||
| } | |||
|
|
|||
| @Test(expected = KaaOptimisticLockingFailureException.class) | |||
| @Test | |||
There was a problem hiding this comment.
Why KaaOptimisticLockingFailureException is not expected anymore in this test?
| configuration.setConfiguration(dto.getConfiguration()); | ||
| configuration.setConfigurationVersion(dto.getConfigurationSchemaVersion()); | ||
| configuration.setEndpointKeyHash(getByteBuffer(dto.getEndpointKeyHash())); | ||
| save(configuration); |
There was a problem hiding this comment.
move a call of save method out of if block
| configuration.setConfiguration(dto.getConfiguration()); | ||
| configuration.setConfigurationVersion(dto.getConfigurationSchemaVersion()); | ||
| configuration.setEndpointKeyHash(dto.getEndpointKeyHash()); | ||
| save(configuration); |
There was a problem hiding this comment.
move a call of save method out of if block
| @@ -26,19 +26,19 @@ | |||
| private byte[] endpointKeyHash; | |||
| private Integer configurationSchemaVersion; | |||
| private String configuration; | |||
| private Long version; | |||
| private Long specificConfigurationVersion; | |||
There was a problem hiding this comment.
Why do we need to rename version -> specificConfigurationVersion in DTO?
| @@ -72,7 +71,7 @@ public void testFindByEndpointKeyHashAndConfigurationVersion() throws Exception | |||
| Assert.assertNull(found4); | |||
| } | |||
|
|
|||
| @Test(expected = KaaOptimisticLockingFailureException.class) | |||
There was a problem hiding this comment.
Why KaaOptimisticLockingFailureException is not expected anymore in this test?
vtkhir
approved these changes
Dec 15, 2016
garniy
approved these changes
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process of updating configuration fixed.