Add basic CI using github actions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootstrap the makefile adding basic targets to run vet and run the unit test suite, both to be used in CI. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
add-ci-gh-actions
branch
from
46c7e71 to
117ea1a
Compare
ffromani
force-pushed
the
add-ci-gh-actions
branch
from
117ea1a to
00e670b
Compare
fmuyassarov
reviewed
Feb 20, 2023
.github/workflows/go.yml
Outdated
Comment on lines
23
to
24
| - name: Vet | ||
| run: go vet ./... |
There was a problem hiding this comment.
should the Makefile target vet be used instead here?
There was a problem hiding this comment.
it's better indeed, fixing
bootstrap the basic CI with go vet and unit tests unit tests proper to be added in future PRs. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
add-ci-gh-actions
branch
from
00e670b to
a4c4677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wire in the minimal CI support with vetting and unit tests
fixes #32