ci(benchmark): query upstream releases for the baseline image#33
Merged
ci(benchmark): query upstream releases for the baseline image#33
Conversation
The fork has no GitHub releases, so 'gh api repos/k8sstormcenter/node-agent /releases/latest' returns 404 and the workflow aborts at 'Resolve before image'. The baseline image referenced in the next line is already the upstream registry (quay.io/kubescape/node-agent), so query upstream's releases endpoint to get a real tag — this also gives a meaningful 'us vs latest upstream release' comparison.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Performance Benchmark workflow aborts at the
Resolve before imagestep because it callsgh api repos/k8sstormcenter/node-agent/releases/latestand our fork has no GitHub releases — returns 404.The next line of the same step already constructs the baseline as
quay.io/kubescape/node-agent:${LATEST_TAG}(upstream registry), so querying upstream's releases endpoint to get the tag is consistent with how the image is then resolved. It also gives us a meaningful 'us vs latest upstream release' comparison.Test plan
Build after imagestep (no longer aborts atResolve before image)Quality gatestep finds before/after metrics and runs to completion🤖 Generated with Claude Code