-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Bump golang.org/x/net to v0.34.0 #449
vendor: Bump golang.org/x/net to v0.34.0 #449
Conversation
Signed-off-by: Ram Lavi <[email protected]>
/cherry-pick release-0.45 |
@RamLavi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please consider using the script, or at least title as the script done, just nice to have /lgtm |
@RamLavi: new pull request created: #451 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I may be too conservative, but I don't like announcing the reason of the bump on the PR. I do attach the U/S PR to the JIRA ticket so the automation moves it during the stages. Shouldn't it be as good as your suggestion?
It doesn't, and it's not a bad idea to add it. |
Np |
What this PR does / why we need it:
This Pr bumps golang.org/x/net to v0.34.0
Special notes for your reviewer:
Release note: