Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Bump golang.org/x/net to v0.34.0 #449

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

RamLavi
Copy link
Member

@RamLavi RamLavi commented Jan 7, 2025

What this PR does / why we need it:
This Pr bumps golang.org/x/net to v0.34.0

Special notes for your reviewer:

Release note:

NONE

@RamLavi
Copy link
Member Author

RamLavi commented Jan 7, 2025

/cherry-pick release-0.45

@kubevirt-bot
Copy link
Collaborator

@RamLavi: once the present PR merges, I will cherry-pick it on top of release-0.45 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi
Copy link
Member Author

RamLavi commented Jan 7, 2025

/retest
opened flaky issue #450

@RamLavi
Copy link
Member Author

RamLavi commented Jan 7, 2025

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Member

oshoval commented Jan 8, 2025

Please consider using the script, or at least title as the script done, just nice to have
Also i remember vaguely that KMP doest run make vendor on CI ? (unless it was fixed)

/lgtm

@kubevirt-bot kubevirt-bot merged commit 9be6f3e into k8snetworkplumbingwg:main Jan 8, 2025
5 checks passed
@kubevirt-bot
Copy link
Collaborator

@RamLavi: new pull request created: #451

In response to this:

/cherry-pick release-0.45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi
Copy link
Member Author

RamLavi commented Jan 8, 2025

Please consider using the script, or at least title as the script done, just nice to have

I may be too conservative, but I don't like announcing the reason of the bump on the PR. I do attach the U/S PR to the JIRA ticket so the automation moves it during the stages. Shouldn't it be as good as your suggestion?

Also i remember vaguely that KMP doest run make vendor on CI ? (unless it was fixed)

It doesn't, and it's not a bad idea to add it.

@oshoval
Copy link
Member

oshoval commented Jan 8, 2025

Np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants