pool-manager: Prevent panic if VM template is nil #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template field is the only pointer in the relevant spec. Checking it is not nil will prevent kubemacpool from panicking Signed-off-by: Ram Lavi <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RamLavi
added a commit
to RamLavi/kubemacpool
that referenced
this pull request
Sep 8, 2024
…plumbingwg#431)" This reverts commit 1478ec9.
RamLavi
added a commit
to RamLavi/kubemacpool
that referenced
this pull request
Sep 8, 2024
…plumbingwg#431)" This reverts commit 1478ec9. Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Revert "pool-manager: Prevent panic if VM template is nil (#431)" This reverts commit 1478ec9. Signed-off-by: Ram Lavi <[email protected]> * vm, webhook: Fix panic on templateless VM former fix [0] was not sufficient. Moving the check earlier in the webhoook handling. Signed-off-by: Ram Lavi <[email protected]> --------- Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot
pushed a commit
to kubevirt-bot/kubemacpool
that referenced
this pull request
Sep 9, 2024
…plumbingwg#431)" This reverts commit 1478ec9. Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot
added a commit
that referenced
this pull request
Sep 9, 2024
* Revert "pool-manager: Prevent panic if VM template is nil (#431)" This reverts commit 1478ec9. Signed-off-by: Ram Lavi <[email protected]> * vm, webhook: Fix panic on templateless VM former fix [0] was not sufficient. Moving the check earlier in the webhoook handling. Signed-off-by: Ram Lavi <[email protected]> --------- Signed-off-by: Ram Lavi <[email protected]> Co-authored-by: Ram Lavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a panic that occurs if a VM is created/updated with no template.
Although this field is mandatory, kubemacpool should not panic if it happens.
Special notes for your reviewer:
Release note: