-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.39] Update dependencies #399
[release-0.39] Update dependencies #399
Conversation
This fixes the broken replacement of github.com/openshift/api and github.com/openshift/client-go by replacing them with the version used in main. Signed-off-by: Felix Matouschek <[email protected]>
This allows updates of github.com/containernetworking/cni by removing the dependency on kubevirt.io/kubevirt. Signed-off-by: Felix Matouschek <[email protected]>
Updated modules golang.org/x/*, github.com/containernetworking/cni and github.com/emicklei/go-restful to the latest versions. Signed-off-by: Felix Matouschek <[email protected]>
Hi @0xFelix. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-kubemacpool-unit-test |
@oshoval: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubemacpool-unit-test-v0.39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Nice job
The unit tests failure is something about podman, need retest
/test pull-kubemacpool-unit-test-v0.39 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fce2cd6
into
k8snetworkplumbingwg:release-0.39
What this PR does / why we need it:
Updated modules golang.org/x/*, github.com/containernetworking/cni and
github.com/emicklei/go-restful to the latest versions.
The broken replacement of github.com/openshift/api and
github.com/openshift/client-go are fixed by replacing them with the version
used in main.
Updates of github.com/containernetworking/cni are allowed again by removing
the dependency on kubevirt.io/kubevirt.
Special notes for your reviewer:
Release note: