Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.39] Update dependencies #399

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

0xFelix
Copy link
Contributor

@0xFelix 0xFelix commented Oct 27, 2023

What this PR does / why we need it:

Updated modules golang.org/x/*, github.com/containernetworking/cni and
github.com/emicklei/go-restful to the latest versions.

The broken replacement of github.com/openshift/api and
github.com/openshift/client-go are fixed by replacing them with the version
used in main.

Updates of github.com/containernetworking/cni are allowed again by removing
the dependency on kubevirt.io/kubevirt.

Special notes for your reviewer:

Release note:

None

This fixes the broken replacement of github.com/openshift/api and
github.com/openshift/client-go by replacing them with the version used
in main.

Signed-off-by: Felix Matouschek <[email protected]>
This allows updates of github.com/containernetworking/cni by removing
the dependency on kubevirt.io/kubevirt.

Signed-off-by: Felix Matouschek <[email protected]>
Updated modules golang.org/x/*, github.com/containernetworking/cni and
github.com/emicklei/go-restful to the latest versions.

Signed-off-by: Felix Matouschek <[email protected]>
@kubevirt-bot
Copy link
Collaborator

Hi @0xFelix. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oshoval
Copy link
Member

oshoval commented Oct 30, 2023

/ok-to-test

@oshoval
Copy link
Member

oshoval commented Oct 30, 2023

/test pull-kubemacpool-unit-test

@kubevirt-bot
Copy link
Collaborator

@oshoval: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubemacpool-e2e-k8s-v0.39
  • /test pull-kubemacpool-unit-test-v0.39

Use /test all to run all jobs.

In response to this:

/test pull-kubemacpool-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oshoval
Copy link
Member

oshoval commented Oct 30, 2023

/test pull-kubemacpool-unit-test-v0.39

Copy link
Member

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Nice job

The unit tests failure is something about podman, need retest

@oshoval
Copy link
Member

oshoval commented Oct 30, 2023

/test pull-kubemacpool-unit-test-v0.39

@qinqon
Copy link
Member

qinqon commented Oct 30, 2023

/lgtm
/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit fce2cd6 into k8snetworkplumbingwg:release-0.39 Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants