Skip to content

NATS Driver Conformance Updates#549

Merged
brandond merged 1 commit intok3s-io:masterfrom
nats-io:sattwood/nats-conformance
Dec 15, 2025
Merged

NATS Driver Conformance Updates#549
brandond merged 1 commit intok3s-io:masterfrom
nats-io:sattwood/nats-conformance

Conversation

@samuelattwood
Copy link
Copy Markdown
Contributor

@samuelattwood samuelattwood commented Nov 7, 2025

  • Brings NATS Backend up-to-date
  • Resolves issues with Kubernetes Conformance test suite
  • Adds read-after-write checks
  • Various fixes and enhancements

@samuelattwood samuelattwood requested a review from a team as a code owner November 7, 2025 23:16
@brandond
Copy link
Copy Markdown
Member

brandond commented Nov 7, 2025 •
edited
Loading

This is great to see! Don't forget to --signoff your commits for DCO.

@samuelattwood samuelattwood force-pushed the sattwood/nats-conformance branch from 801f07f to 9262069 Compare November 7, 2025 23:27
brandond
brandond requested changes Nov 7, 2025
View reviewed changes
@DeanKamali
Copy link
Copy Markdown

DeanKamali commented Nov 13, 2025

Any update on this? @samuelattwood

I have some time to dedicate for this, let me know if I can do any reviews or pick up any blockers.

@samuelattwood
Copy link
Copy Markdown
Contributor Author

samuelattwood commented Nov 13, 2025

There is a small fix I had to make after enabling the apiserver tests that wasn't caught by the Sonobuoy conformance suite.

I have been at KubeCon this week but I will have that up tomorrow or Monday, in addition to some improvements regarding tombstones.

@samuelattwood samuelattwood force-pushed the sattwood/nats-conformance branch from 6291ab3 to 6c05e8a Compare November 19, 2025 09:18
brandond
brandond requested changes Nov 19, 2025
View reviewed changes
@brandond
Copy link
Copy Markdown
Member

brandond commented Dec 10, 2025

@samuelattwood are you still working on this?

@samuelattwood samuelattwood force-pushed the sattwood/nats-conformance branch from 33b38eb to 29aef7a Compare December 10, 2025 23:49
@brandond
Copy link
Copy Markdown
Member

brandond commented Dec 11, 2025

  1. Can you rebase onto master? CI has been moved from Drone to GHA.
  2. Would nats benefit from using the waitgroup to wait until it's shut down properly, or is it OK to just exit as soon as the context is cancelled?

@samuelattwood
Copy link
Copy Markdown
Contributor Author

samuelattwood commented Dec 11, 2025

@brandond Yep, I will have a rebase up shortly. I'm fixing something with the embedded test I ran into after rebasing.

Waitgroup is probably a good idea, I will add that as well.

@samuelattwood samuelattwood force-pushed the sattwood/nats-conformance branch 2 times, most recently from daf688e to 1f8bb9d Compare December 11, 2025 03:15
@brandond
Copy link
Copy Markdown
Member

brandond commented Dec 11, 2025

Sorry, I pushed another round of changes to CI; would you mind rebasing again? I think we're very close to done with this.

@samuelattwood samuelattwood force-pushed the sattwood/nats-conformance branch 2 times, most recently from 9609f49 to 202655f Compare December 11, 2025 14:57
@brandond
Copy link
Copy Markdown
Member

brandond commented Dec 11, 2025

LGTM! Would you like to do some cleanup on the commit history and fixup/squash the various fix/test/wip commits, or should I just squash when merging?

@brandond brandond mentioned this pull request Dec 11, 2025
Open
@samuelattwood
Copy link
Copy Markdown
Contributor Author

samuelattwood commented Dec 11, 2025

@brandond I will squash some of the commits in just a minute

@samuelattwood
Improvements and conformance fixes
c64beed 
Add compaction check to watch

Improve watch

Uncomment NATS tests

Remove signal handler from nats driver

Add waitgroup to nats driver. Fix port conflict in embedded test

Address golangci-lint issues

Signed-off-by: Samuel Attwood <sam@nats.io>
@samuelattwood samuelattwood force-pushed the sattwood/nats-conformance branch from 202655f to c64beed Compare December 11, 2025 22:20
@brandond brandond merged commit 52aa8b8 into k3s-io:master Dec 15, 2025
21 checks passed
This was referenced Jan 7, 2026
Closed
Open
brandond added a commit to brandond/k3s that referenced this pull request Jan 7, 2026
@brandond
Bump kine for NATS conformance fixes
041ab4c 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond mentioned this pull request Jan 7, 2026
Merged
brandond added a commit to brandond/k3s that referenced this pull request Jan 8, 2026
@brandond
Bump kine for NATS conformance fixes
6889ac4 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
e9e99af 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
8c3587d 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
f6aa1dd 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
fa27d94 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
01f972d 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
81f8e7d 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
f028f77 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Jan 9, 2026
@brandond
Bump kine for NATS conformance fixes
46d904f 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 10, 2026
@brandond
Bump kine for NATS conformance fixes
bbae258 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 10, 2026
@brandond
Bump kine for NATS conformance fixes
cae5c93 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Jan 10, 2026
@brandond
Bump kine for NATS conformance fixes
e05a24a 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Jan 10, 2026
@brandond
Bump kine for NATS conformance fixes
97d81bf 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Jan 10, 2026
@brandond
Bump kine for NATS conformance fixes
ceeff68 
Includes the long-awaited fixes from
* k3s-io/kine#549

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8c3587d)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@babykart babykart mentioned this pull request Mar 1, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandond brandond brandond approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samuelattwood @brandond @DeanKamali