Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compact transaction #360

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix compact transaction #360

merged 2 commits into from
Nov 8, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Nov 8, 2024

@brandond
Set go-sqlite3 tx lock type to IMMEDIATE
c17ab22 
Workaround for mattn/go-sqlite3#685

Signed-off-by: Brad Davidson <[email protected]>
@brandond
Record compact progress and metrics per iteration
c9be9a7 
Fixes issue where compact progress was only recorded in metrics and loop var if all iterations succeeded, despite progress being made within individual iterations of the inner loop.

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner November 8, 2024 21:48
VestigeJ
VestigeJ approved these changes Nov 8, 2024
View reviewed changes
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandond brandond merged commit aa4f2a7 into k3s-io:master Nov 8, 2024
3 checks passed
This was referenced Nov 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereknola dereknola dereknola approved these changes

@VestigeJ VestigeJ VestigeJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandond @VestigeJ @dereknola