Skip to content

[Release-1.28] Add tls for kine#9849

Merged
vitorsavian merged 1 commit intok3s-io:release-1.28from
vitorsavian:kine-tls-release-1.28
Apr 2, 2024
Merged

[Release-1.28] Add tls for kine#9849
vitorsavian merged 1 commit intok3s-io:release-1.28from
vitorsavian:kine-tls-release-1.28

Conversation

@vitorsavian
Copy link
Copy Markdown
Member

Issue #9847
Backport from #9572

@vitorsavian vitorsavian requested a review from a team as a code owner April 1, 2024 16:14
@vitorsavian vitorsavian changed the title Add tls for kine [Release-1.28] Add tls for kine Apr 1, 2024
* Bump kine
* Add integration tests for kine with tls

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian force-pushed the kine-tls-release-1.28 branch from be33b52 to 09ac65a Compare April 1, 2024 17:10
Copy link
Copy Markdown
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but e2e failed. I restarted it to see if it was a flake.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 26.76%. Comparing base (ae8f23b) to head (09ac65a).

Files Patch % Lines
pkg/cluster/storage.go 7.14% 11 Missing and 2 partials ⚠️
pkg/cluster/cluster.go 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.28    #9849       +/-   ##
=================================================
- Coverage         45.65%   26.76%   -18.89%     
=================================================
  Files               154      154               
  Lines             15857    16811      +954     
=================================================
- Hits               7240     4500     -2740     
- Misses             7324    11519     +4195     
+ Partials           1293      792      -501     
Flag Coverage Δ
e2etests 0.00% <0.00%> (-49.31%) ⬇️
inttests 21.17% <60.52%> (?)
unittests 15.47% <16.21%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 70bd377 into k3s-io:release-1.28 Apr 2, 2024
@vitorsavian vitorsavian deleted the kine-tls-release-1.28 branch May 20, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants