Use and version flannel/cni-plugin properly#9635
Merged
brandond merged 1 commit intok3s-io:masterfrom Mar 4, 2024
Merged
Conversation
Moves us closer to using the proper upstream for our flannel CNI plugin, instead of the snapshot that is vendored into our plugins fork. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9635 +/- ##
==========================================
- Coverage 45.88% 42.94% -2.94%
==========================================
Files 151 154 +3
Lines 13509 13564 +55
==========================================
- Hits 6198 5825 -373
- Misses 6080 6561 +481
+ Partials 1231 1178 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vitorsavian
approved these changes
Mar 4, 2024
dereknola
approved these changes
Mar 4, 2024
This was referenced Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use and version flannel/cni-plugin properly
Moves us closer to using the proper upstream for our flannel CNI plugin, instead of the snapshot that is vendored into our plugins fork. In the future, we can drop the flannel plugin from our fork entirely, to better align with the upstream plugins project. It will also ensure that fixes like flannel-io/cni-plugin#46 are no longer accidentally omitted from making it into k3s.
Types of Changes
tech debt
Verification
Check versions - note that flannel cni plugin version is no longer the same as the flannel version
Testing
Linked Issues
User-Facing Change
Further Comments