Merged
Conversation
e60040d to
25b720c
Compare
dereknola
previously approved these changes
Feb 29, 2024
25b720c to
7bf1bf3
Compare
vitorsavian
previously approved these changes
Mar 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9599 +/- ##
==========================================
- Coverage 45.88% 42.81% -3.07%
==========================================
Files 151 154 +3
Lines 13509 13534 +25
==========================================
- Hits 6198 5795 -403
- Misses 6080 6570 +490
+ Partials 1231 1169 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
previously approved these changes
Mar 1, 2024
vitorsavian
previously approved these changes
Mar 1, 2024
galal-hussein
previously approved these changes
Mar 1, 2024
Signed-off-by: Philip Laine <philip.laine@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
vitorsavian
approved these changes
Mar 4, 2024
dereknola
approved these changes
Mar 4, 2024
This was referenced Mar 5, 2024
This was referenced Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
based on changes from #9365
latesttagTypes of Changes
version bump
enhancement
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments