Rework Install Tests

[dereknola]

Signed-off-by: Derek Nola [email protected]

Proposed Changes

• Remove cgroup v2 standalone test. It was incredibly flaky, and Ubuntu 22.04 and Rocky 9 support cgroupv2 by default, it no longer needs a standalone test.
• Add Ubuntu 22.04 as a standard install test
• Consolidate all the install test checks into functions
• Add a retry around vagrant up for the btrfs snapshotter test. Manually debugging on the runner review that often the VM will come up on the second try, indicating a race condition in Virtualbox. Unfortunately, we cannot move to something like libvirt due to technical limitations on the macOS runners.

Types of Changes

Verification

Testing

Linked Issues

#8591

User-Facing Change

Further Comments

[brandond]

💯

[dereknola]

The root issue seems to stem from macos-12 runners having a old version of VirtualBox pinned from about a year ago in actions/runner-images#6391. Virtualbox has seens been patched to support new versions of macOS, but Github Actions never "unpinned" the version. The guru meditation errors have gotten more and more prevalent and thus I have have:

• Disabled at the repo level the cgroup install and snapshotter actions
• Opened an issue to have the VirtualBox image either "unpinned" or at least updated to the latest 7.0.12 version.

This PR is ready to be merged, however its effects will not be seen until such time that vagrant + virtualbox on GitHub Actions is a viable option again.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de82584) 49.42% compared to head (1cabce9) 39.48%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8674      +/-   ##
==========================================
- Coverage   49.42%   39.48%   -9.94%     
==========================================
  Files         151      151              
  Lines       13475    13475              
==========================================
- Hits         6660     5321    -1339     
- Misses       5474     6996    +1522     
+ Partials     1341     1158     -183     

Flag	Coverage Δ
e2etests	?
inttests	39.48% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dereknola]

Closing this PR to reopen a new one. Alot has happened that this PR is to out of date