Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token startup test #7442

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix token startup test #7442

merged 1 commit into from
May 5, 2023

Conversation

brandond
Copy link
Member

@brandond brandond commented May 5, 2023

Proposed Changes

Fix startup e2e test

Types of Changes

bugfix, testing

Verification

Check CI logs

Testing

yes

Linked Issues

User-Facing Change

NONE

Further Comments

Fixes e2e failure:

• [FAILED] [6.012 seconds]
Various Startup Configurations Verify server fails to start with bootstrap token [It] Fails to start with a meaningful error
/drone/src/tests/e2e/startup/startup_test.go:256

  [FAILED] ContainSubstring matcher requires a string or stringer.  Got:
      <*e2e.NodeError | 0xc000111d10>: 
      failed creating cluster: sudo systemctl start k3s: failed to run command: sudo systemctl start k3s on node server-0: Job for k3s.service failed because the control process exited with error code.
      See "systemctl status k3s.service" and "journalctl -xe" for details.
      , exit status 1
      {
          Node: "server-0",
          Cmd: "sudo systemctl start k3s",
          Err: <*errors.errorString | 0xc0001e47f0>{
              s: "failed to run command: sudo systemctl start k3s on node server-0: Job for k3s.service failed because the control process exited with error code.\nSee \"systemctl status k3s.service\" and \"journalctl -xe\" for details.\n, exit status 1",
          },
      }

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner May 5, 2023 20:11
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf9ebb3) 19.48% compared to head (b3f5f4c) 19.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7442   +/-   ##
=======================================
  Coverage   19.48%   19.48%           
=======================================
  Files          81       81           
  Lines        5497     5497           
=======================================
  Hits         1071     1071           
  Misses       4204     4204           
  Partials      222      222           
Flag Coverage Δ
unittests 19.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandond brandond merged commit c98137d into k3s-io:master May 5, 2023
@brandond brandond deleted the fix_startup_test branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants