Pin golangci-lint version to v1.51.2#7113
Merged
brooksn merged 2 commits intoMar 20, 2023
Merged
Conversation
Signed-off-by: Brooks Newberry <brooks@newberry.com>
Signed-off-by: Brooks Newberry <brooks@newberry.com>
brooksn
changed the title
This was referenced Mar 20, 2023
briandowns
approved these changes
Mar 20, 2023
cwayne18
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The golangci-lint installer downloads the latest GitHub tag. This PR passes a specified tag to the installer.
Types of Changes
Verification
Testing
Linked Issues
#7114
#7115
User-Facing Change
Further Comments
Since golangci-lint v1.52.0 was released, a lot of warnings from revive started to appear for these rules:
They don't appear to be false positives, and it's not immediately clear what changed in the linter. An alternate solution is to fix all these violations now, or to add them all to the exclude list.