skip all pipelines based on what is in the PR#6996
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6996 +/- ##
======================================
Coverage 9.65% 9.65%
======================================
Files 146 146
Lines 10738 10738
======================================
Hits 1037 1037
Misses 9483 9483
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
left a comment
There was a problem hiding this comment.
I'm not sure what's going on with all the commits that have been added to this branch after approval; please get it back to just the single change before merging.
|
sorry, I will. I was finally able to test this and it doesn't work... :( |
|
converting this to a draft so I don't spam reviewers |
340e8fd to
85a0ea5
Compare
|
I put everything into a single commit, I believe this is ready for review. |
| volumes: | ||
| - name: docker | ||
| host: | ||
| path: /var/run/docker.sock |
There was a problem hiding this comment.
the diff is unclear here, but if you look at the file I just removed some spacing here to conform to the way the rest of the yaml is written (lists have same spacing as parent)
|
|
||
| Security issues in K3s can be reported by sending an email to [security@k3s.io](mailto:security@k3s.io). Please do not file issues about security issues. | ||
| Security issues in K3s can be reported by sending an email to [security@k3s.io](mailto:security@k3s.io). | ||
| Please do not file issues about security issues. |
There was a problem hiding this comment.
This is a trivial spacing change to validate that .md files are ignored.
85a0ea5 to
6148ff1
Compare
…drone config to use droneignore to skip CI when files are all matched Signed-off-by: matttrach <matttrach@gmail.com>
865e5b0 to
00993dc
Compare
cwayne18
left a comment
There was a problem hiding this comment.
This looks neat thanks! Can we add .github/*, MAINTAINERS, CODEOWNERS to the skip list please?
… list Signed-off-by: matttrach <matttrach@gmail.com>
|
done. Also added DCO, channel.yaml, and LICENSE (although they are unlikely to change) |
dereknola
left a comment
There was a problem hiding this comment.
Is is possible to put all the repeated bash commands into a script file and just call that?
|
I think the special exit code has to be executed from the root scope, I can probably add a file and execute it, but it would only reduce 1 line of code per copy. |
There was a problem hiding this comment.
Do we want this on all CI runs, or just on PR? It feels like we should never skip running CI on merges or tags - basically anything that runs on drone-publish. Should we add something to restrict this to just pull branches on drone-pr?
trigger:
instance:
- drone-pr.k3s.io
ref:
- refs/pull/*/headSigned-off-by: matttrach <matttrach@gmail.com>
|
Definitely don't wanna skip on tags, thanks! |
Proposed Changes
This change will add a pipeline which implements drone-skip-pipeline.
The purpose is to provide some mechanism to automatically skip pipelines which are not necessary due to the files that are being changed. For example, if a markdown file is the only file changed, then we don't need to run functional tests. This will reduce our integration time.
Types of Changes
No new code to k3s, all changes in .drone.yml
Verification
Unfortunately, Drone provides no way to test this outside of letting it run in your repo.
Linked Issues
This addresses #6980.
User-Facing Change
This has no user facing change.
Further Comments
There is another plugin which may give us similar functionality, but is out of date and requires configuration on the drone server, I would like to try this one first to avoid the additional handoffs.
There is more than one way to implement this plugin, the way I have provided is the one with the fewest changes to existing steps, I am open to additional suggestions.