[WIP] Convert flannel bools to single stringslice#6897
Closed
dereknola wants to merge 2 commits intok3s-io:masterfrom
Closed
[WIP] Convert flannel bools to single stringslice#6897dereknola wants to merge 2 commits intok3s-io:masterfrom
dereknola wants to merge 2 commits intok3s-io:masterfrom
Conversation
Signed-off-by: Derek Nola <derek.nola@suse.com>
rbrtbnfgl
approved these changes
Feb 9, 2023
Member
|
This sounds a lot like what @manuelbuil was attempting in #6557 and we ultimately decided against. I still thing it's worth doing an ADR for the Flannel CLI stuff since we keep revisiting it. |
Merged
Contributor
|
Hey @dereknola should we keep this one open or close? |
Member
Author
|
I closed it.... This never went anywhere |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
flannel-optionsflag.Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments