Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with RKE2 server hanging on startup when listing apiserver addresses #5437

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Fix issue with RKE2 server hanging on startup when listing apiserver addresses #5437

merged 4 commits into from
Apr 15, 2022

Conversation

brandond
Copy link
Member

@brandond brandond commented Apr 14, 2022 •
edited
Loading

Proposed Changes

  • Fix issue with RKE2 servers hanging on listing apiserver addresses.
  • Print a helpful error when trying to join additional servers but etcd is not in use.
  • Move IPv4/v6 selection into helpers.
  • Use upstream group constants.

Types of Changes

Bugfix/cleanup

Verification

  • Verify that K3s starts up as usual.
  • Verify that RKE2 starts up as usual, when this PR is pulled through.
  • Try to join an additional server to the cluster when etcd is not in use; note the helpful warning on the first server.

Linked Issues

User-Facing Change

NONE

Further Comments

@brandond brandond requested a review from a team as a code owner April 14, 2022 20:10
@brandond brandond force-pushed the fix-tunnel-apiserver-seed branch from 4ddffd2 to 0af77ad Compare April 14, 2022 20:38
brandond added 3 commits April 14, 2022 17:29
@brandond
Use core constants for cert user/group values
640741a 
Also update cert gen to ensure leaf certs are regenerated if other key fields change.

Signed-off-by: Brad Davidson <[email protected]>
@brandond
Print a helpful error when trying to join additional servers but etcd…
7d22728 
… is not in use

Signed-off-by: Brad Davidson <[email protected]>
@brandond
Fix issue with RKE2 servers hanging on listing apiserver addresses
1fabdfa 
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the fix-tunnel-apiserver-seed branch from 0af77ad to ce9234f Compare April 15, 2022 00:32
@brandond brandond merged commit b12cd62 into k3s-io:master Apr 15, 2022
This was referenced Apr 15, 2022
Merged
Merged
Merged
@cguertin14 cguertin14 mentioned this pull request May 6, 2022
Merged
This was referenced May 20, 2022
Merged
Closed
@brandond brandond deleted the fix-tunnel-apiserver-seed branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@dereknola dereknola dereknola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandond @briandowns @dereknola