Require integration test to be run as sudo/root #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
briandowns
reviewed
Dec 22, 2021
briandowns
reviewed
Dec 22, 2021
brandond
approved these changes
Dec 22, 2021
Signed-off-by: Derek Nola <[email protected]>
briandowns
approved these changes
Dec 22, 2021
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Dec 23, 2021
* Remove internal sudo commands from integration tests * Run integration CI as sudo Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jan 3, 2022
* Remove internal sudo commands from integration tests * Run integration CI as sudo Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As discussed in #4372, this rips out all the "sudo" commands within the K3s integration utility functions. It is now required that integration tests have root permissions when run.
Updated documentation on this.
Types of Changes
Test Fix
Verification
As sudo user:
sudo -E env "PATH=$PATH" go test ./pkg/... ./tests/integration/... -run IntegrationAs root:
go test ./pkg/... ./tests/integration/... -run IntegrationLinked Issues
N/A internal testing change only, nothing for QA to do.
User-Facing Change
Further Comments