-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes local storage pods to have 700 permissions #3537
Conversation
Signed-off-by: dereknola <[email protected]>
Signed-off-by: dereknola <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Changes local storage pods to have 700 permissions Signed-off-by: dereknola <[email protected]>
* Changes local storage pods to have 700 permissions Signed-off-by: dereknola <[email protected]>
This broke all volumes for containers running not as root. See #3704, which reported this as a k3s regression. From rancher/local-path-provisioner#182 (comment),
|
@flokli if you look at the bottom of that issue you should see linked PRs for every branch resolving the regression. The fix will be included in the next release. |
@brandond let's take the discussion over to #2348 (comment). |
Signed-off-by: dereknola [email protected]
Proposed Changes
Individual storage pods under
/var/lib/rancher/k3s/storage
will now have 0700 permissions to prevent other users from accessing them.Types of Changes
Changed mkdir call in
local-storage.yaml
Verification
/var/lib/rancher/k3s/storage/
has 0700 permissionsLinked Issues
#2348