cgroup: move proccesses from root group to new /init group #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
added a commit
to k3d-io/k3d
that referenced
this pull request
Apr 28, 2021
- Cgroupv2 fix as per k3s-io/k3s#3237 & k3s-io/k3s#3242
iwilltry42
force-pushed
the
fix/cgroupv2
branch
from
3afc99e
to
c9f8c46
Compare
brandond
approved these changes
Apr 28, 2021
AkihiroSuda
suggested changes
May 1, 2021
|
Can we have CI for cgroup2? (#2887) 🙏 |
(this is merged) |
iwilltry42
force-pushed
the
fix/cgroupv2
branch
2 times, most recently
from
b6b1d50
to
8d27d8f
Compare
|
Lets see how the tests look, but you need signoff on your commits. |
AkihiroSuda
suggested changes
May 6, 2021
|
Could you rebase with #3282 to test the change with rootless? |
AkihiroSuda
suggested changes
May 6, 2021
AkihiroSuda
reviewed
May 6, 2021
AkihiroSuda
reviewed
May 6, 2021
AkihiroSuda
reviewed
May 7, 2021
AkihiroSuda
reviewed
May 7, 2021
AkihiroSuda
reviewed
May 7, 2021
|
This looks good, but needs a rebase in order to get the CI checks to run. |
iwilltry42
force-pushed
the
fix/cgroupv2
branch
2 times, most recently
from
322cd44
to
bbe764d
Compare
|
need rebase code base |
- Ref: see discussion at k3s-io#3237 Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
…groups Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
|
@xiaods done ✔️ |
|
Closing as Out of Date and has been superseded by other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If there are processes running in the root cgroup on a cgroupv2 enabled system, move them to a new
/initgroup and enable subtree_control.For further info, see the discussion and links in the previous PR: #3237
Types of Changes
Fix for cgroupv2 support.
Verification
Run on a cgroupv2 enabled system
Linked Issues
Further Comments
This is my first time touching cgroups in Go code and reading/writing that part of the k3s code, so there may be some things that could be done different.
The way it's written now, it should only have an effect if there are processes running under the root cgroup.